-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(statesync): implement statesync spec for the new approach #655
Merged
shotonoff
merged 22 commits into
v0.13-dev
from
feat/statesync-implement-spec-for-new-approach
Jul 19, 2023
Merged
feat(statesync): implement statesync spec for the new approach #655
shotonoff
merged 22 commits into
v0.13-dev
from
feat/statesync-implement-spec-for-new-approach
Jul 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lklimek
reviewed
Jul 14, 2023
Co-authored-by: lklimek <[email protected]>
Co-authored-by: lklimek <[email protected]>
Co-authored-by: lklimek <[email protected]>
shotonoff
commented
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please have a look at the modifications and answers
lklimek
reviewed
Jul 18, 2023
lklimek
reviewed
Jul 18, 2023
shotonoff
commented
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the PR is ready to review
lklimek
previously approved these changes
Jul 19, 2023
lklimek
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
To be able to perform state synchronization in Dash Platform, Tenderdash must be compatible with some restriction of GroveDB.
This PR contains the changes of a new approach state synchonization, that is described in specification
What was done?
How Has This Been Tested?
Unit Tests / E2E tests
Breaking Changes
The original way of replicating state synchronization is obsolete and has been replaced by another approach
Checklist:
For repository code-owners and collaborators only